Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-15939: NOT FOR REVIEW - add 4 new avro schemas for key rotation, two new kafka messages #1232

Merged
merged 20 commits into from
Nov 3, 2023
Merged

CORE-15939: NOT FOR REVIEW - add 4 new avro schemas for key rotation, two new kafka messages #1232

merged 20 commits into from
Nov 3, 2023

Conversation

anien
Copy link
Contributor

@anien anien commented Sep 4, 2023 •
edited
Loading

NOT FOR REVIEW

To facilitate the crypto key rotation, 4 new avro schemas and two new Kafka messages were defined.

Design doc: Key rotation

Runtime-os PR: 4578

@anien anien requested a review from a team as a code owner September 4, 2023 13:46
@anien anien marked this pull request as draft September 4, 2023 13:47
@anien anien mentioned this pull request Sep 4, 2023
Merged
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 4, 2023 •
edited
Loading

Jenkins build for PR 1232 build 17

Build Successful:
Jar artifact version produced by this PR: 5.1.0.38-alpha-1697642624065

@anien anien force-pushed the anna/CORE-15939-add-rekey-avro-schemas branch from accc1e9 to b63c97d Compare September 20, 2023 09:26
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 26, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1232/9/ has failed for PR 1232 build 9

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@driessamyn driessamyn removed the request for review from a team September 28, 2023 13:31
anien and others added 16 commits October 17, 2023 08:25
@anien
Add first version of CryptoRewrapRequest avro schema
cbd60ee
@dickon @anien
add topics for rewrap+rekey
d2f9f37
@anien
Fix typo in the topic var
21c4016
@anien
Add new request and response for a rekey operation
b498047
@anien
Bump version
219e313
@anien
Rename avro schemas, update KeyRotation schemas according the design …
855ba31 
…doc, rename kafka topics
@anien
Add new lines
97efe4d
@anien
Rename KeyRotation response to status
30d8765
@anien
Add requestID to request schema and rename few properties
911c3db
@anien
Add response message and add request id to request message
3eb77b9
@anien
Change duration time in avro, fix indentation
cc5db91
@anien
Add response topics for rekey and rewrap
fca854d
@anien
Fix the var names and add start and end timestamp for key rotation
ffccc1b
@anien
Update timestamps in the avro schemas, status schema contains the sta…
711b2eb 
…rt time now
@anien
Update kdoc
93bd0db
@anien
Update avro schemas and topic names for key rotation
59f4162
@anien anien force-pushed the anna/CORE-15939-add-rekey-avro-schemas branch from 3eec3d5 to 59f4162 Compare October 17, 2023 07:25
@anien anien changed the base branch from feature/CORE-12165/key-rotation to release/os/5.1 October 17, 2023 09:55
@anien anien changed the base branch from release/os/5.1 to feature/CORE-12165/key-rotation October 17, 2023 09:56
@dickon dickon merged commit f5a7d3a into feature/CORE-12165/key-rotation Nov 3, 2023
@dickon dickon deleted the anna/CORE-15939-add-rekey-avro-schemas branch November 3, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anien @dickon